Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi compared,
swift-platform-core has set Swift 6.2 and macOS 26 as the minimum supported platform. I have update VirtualTerminal to match. In doing so I bumped into a few build issues which I had help from AI in solving. The main one continuing use of
wcwidth_lwhich we need to bring in fromxlocale.h.Feels kinda ugly having to add another target but I can confirm this works on macOS 26 and Ubuntu 24.04. Do you have any suggestions of how I could improve this?
Thanks,
Zane